feat: add upgrade window check for environmentd image ref #34327
+205
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new method to check if the current environmentd image reference is within the upgrade window of the last successful rollout. We default the image ref to the current version if status is not set.
SangJunBak
force-pushed
the
jun/unskippable-release
branch
from
edf7339 to
13a8710
Compare
Contributor
doy-materialize
left a comment
doy-materialize
left a comment
There was a problem hiding this comment.
conceptually this seems fine, but can we reuse the existing logic for checking the version compatibility? we already have an implementation of this in cloud via is_valid_upgrade_image_ref, and i think it'd be better to pull that code out to the materialize repo and use it in both places
SangJunBak
force-pushed
the
jun/unskippable-release
branch
from
f5b4577 to
b547b8f
Compare
Contributor
Author
|
@doy-materialize done in the latest commit and created a followup cloud PR https://github.com/MaterializeInc/cloud/pull/11901. More or less copied the code and tests. Two things:
|
The plan is to use this public static function in the Cloud repo. Borrows most of the same logic, but allows upgrades from/to dev versions.
SangJunBak
force-pushed
the
jun/unskippable-release
branch
from
b547b8f to
96da51f
Compare
doy-materialize
approved these changes
Dec 3, 2025
def-
reviewed
Dec 5, 2025
| if next_version.major != active_version.major { | ||
| if next_version.major == 26 | ||
| && active_version.major == 0 | ||
| && active_version.minor == 164 |
Contributor
There was a problem hiding this comment.
(with a specific patch version)
Contributor
There was a problem hiding this comment.
ah, right, it should be both (i forgot about that since we weren't deploying those versions to cloud)
def-
reviewed
Dec 5, 2025
| (Version::new(0, 83, 0), Version::new(0, 83, 1)), | ||
| (Version::new(0, 83, 0), Version::new(0, 83, 2)), | ||
| (Version::new(0, 83, 2), Version::new(0, 83, 10)), | ||
| (Version::new(0, 164, 0), Version::new(26, 0, 0)), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new method to check if the current environmentd image reference is within the upgrade window of the last successful rollout. We default the image ref to the current version if status is not set.
Not sure if this is the best way to solve this! One nice thing is we'll see the last version everytime we upgrade which can be useful.
An edge case is if the user's materialize CR status is already set, then it won't have
last_completed_rollout_environmentd_image_refuntil the next successful rollout. So hypothetically, users onv26.0.0can jump straight tov28.0.0if they didn't upgrade between then.We solve this by relaxing the check as much as possible, also in case of other false positives.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.